Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow get_project_id to take a request #1203

Merged
merged 6 commits into from
Jan 9, 2023
Merged

fix: allow get_project_id to take a request #1203

merged 6 commits into from
Jan 9, 2023

Conversation

ScruffyProdigy
Copy link
Contributor

No description provided.

BigTailWolf
BigTailWolf approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@BigTailWolf BigTailWolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BigTailWolf BigTailWolf requested a review from a team as a code owner January 6, 2023 18:24
@arithmetic1728
Copy link
Contributor

Will merge after #1210 is submitted

@arithmetic1728 arithmetic1728 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 9, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 9, 2023
@arithmetic1728 arithmetic1728 merged commit 9a4d23a into googleapis:main Jan 9, 2023
@release-please release-please bot mentioned this pull request Jan 9, 2023
Merged
@ScruffyProdigy ScruffyProdigy deleted the get_project_id branch January 11, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arithmetic1728 arithmetic1728 arithmetic1728 approved these changes

@lsirac lsirac lsirac approved these changes

@BigTailWolf BigTailWolf BigTailWolf approved these changes

@sai-sunder-s sai-sunder-s Awaiting requested review from sai-sunder-s

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ScruffyProdigy @arithmetic1728 @BigTailWolf @lsirac