fix: Update token refresh threshold from 20 seconds to 5 minutes #1146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai-sunder-s
requested review from
a team and
arithmetic1728
as code owners
parthea
approved these changes
Sep 20, 2022
clundin25
added a commit
to clundin25/google-auth-library-python
that referenced
this pull request
Sep 26, 2022
…tes (googleapis#1146)" This reverts commit 261a561.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCE metadataserver refreshes tokens atleast 5mins before expiry. So we can try to refresh if token will expire within next 5 mins. Java uses the same 5mins clock skew.