fix: async system tests regression #1086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clundin25
requested review from
a team,
TimurSadykov,
arithmetic1728 and
sai-sunder-s
as code owners
clundin25
force-pushed
the
fix-system-tests
branch
4 times, most recently
from
1b50adb to
d22b2f8
Compare
clundin25
changed the title
sai-sunder-s
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
sai-sunder-s
approved these changes
Jul 22, 2022
sai-sunder-s
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Currently the system tests were failing with a message "TypeError: 'async_generator' object is not callable". This is because newer versions of pytest_asyncio uses "strict" mode by default which does not automatically convert fixtures to async fixtures in async test cases. This became an issue as of pytest_asyncio version 19. The solution is to either switch the mode to "auto" in the nox commandline or to mark the async fixtures as async fixtures. I've opted for the second to avoid making this hard to discover.
clundin25
force-pushed
the
fix-system-tests
branch
from
d22b2f8 to
761d602
Compare
alexander-fenster
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the system tests were failing with a message "TypeError:
'async_generator' object is not callable".
This is because newer versions of pytest_asyncio uses "strict" mode
by default which does not automatically convert fixtures to async
fixtures in async test cases. This became an issue as of pytest_asyncio
version 19.
The solution is to either switch the mode to "auto" in the nox
commandline or to mark the async fixtures as async fixtures.
I've opted for the second to avoid making this hard to discover.