fix: silence TypeError during tear down stage #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidizheng
changed the title
lidizheng
changed the title
lidizheng
force-pushed
the
fix-type-error
branch
from
327e15b
to
a16cf1c
Compare
lidizheng
requested review from
arithmetic1728,
sai-sunder-s and
a team
as code owners
|
@arithmetic1728 PTAL. The failed test cases don't look related to this PR. |
|
@lidizheng Thank you! Yes, the credential for system test is expired, I will fix it. |
arithmetic1728
approved these changes
Apr 21, 2022
|
Will merge this PR after #1028 is merged. |
arithmetic1728
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #1016
This PR adds a workaround to silence the TypeError. The root cause of the issue sits in CPython, it's unlikely for us to remove this workaround any time soon.