Measure ad-related layout shift #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jburger424
reviewed
Jun 10, 2020
|
|
||
| // Maybe we should look at the parent elements (created by the publisher and | ||
| // passed to the ad tag) rather than the iframe itself. | ||
| const ads = iframes.filter(isGptIframe); |
There was a problem hiding this comment.
Does it make sense to filter only ads in the viewport?
There was a problem hiding this comment.
i don't think so. Layout shift events are already limited to user-visible events and there shouldn't be too many ads for this to be a performance concern.
There was a problem hiding this comment.
But I'll see how much code complexity it adds
jburger424
approved these changes
Jun 16, 2020
jonkeller
reviewed
Jun 16, 2020
jonkeller
approved these changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Measures ad-related layout shift by summing scores across layout shifts where the
old_rectwas later occupied by an ad.Some possible TODOs for follow-up PRs
Feedback would be appreciated