Update fuzzer.cpp Improve Memory Safety and Optimize String Handling in Fuzzer #12816
Conversation
|
Shivam7-1 is a new contributor to projects/rapidjson. The PR must be approved by known contributors before it can be merged. The past contributors are: tyler92, DonggeLiu, inferno-chromium, devtty1er, Dor1s, guidovranken |
|
Hii @tyler92 @DonggeLiu Could Team Please Review This PR |
|
LGTM, but I was going to move this target to the So, right now we can merge it but later I will have to revert this change. UPD: I wrote one comment |
|
Hii @tyler92 Thanks For Reviewing I’ve updated the code accordingly to address the null-termination issue. The std::string is now used to ensure the input passed to rapidjson::Parse is null-terminated, while std::string_view is retained for output handling where null-termination is not required, preserving efficiency and correctness. |
|
Hii @tyler92 Could you please Review This PR again |
|
LGTM, but still - comment. So, up to oss-fuzz's maintainers |
There was a problem hiding this comment.
I'm not really against this, however, i'm not really sure what the gain is tbh. I'm not a fan of introducing a check on size == 0 and I'm not really familiar with string view. There may be some technical gains, but I'm not sure this harness is in need of this as such.
I'd probably prefer to simply go for upstreaming this and then take improvements on the harness from there.
|
Hii @DavidKorczynski This PR is Approved Could Please merge it |
|
Hii @DavidKorczynski Thanks For Reply Could You le me know But what Exactly should I do it ? For explanation about changes here it is |
|
@DavidKorczynski I will move it upstream, but I wanted to have coverage build to be fixed before. Right now I don't understand if this issue related to the infrastructure or something wrong with the fuzzer. It's about #12660 (comment) |
PR Description: Enhanced memory safety by adding checks for empty input and optimized string handling using std::string_view to reduce redundant conversions. These improvements increase performance and robustness during fuzzing by minimizing unnecessary memory allocations and ensuring efficient processing of input data.
Key Changes in the Code:
Added a check for empty input at the start of LLVMFuzzerTestOneInput.
Ensured operations on non-empty strings with checks like if (!result.empty()).
Replaced std::string with std::string_view for more efficient handling of the input data and the resulting string from the buffer.
Avoided copying the data unnecessarily by directly working with std::string_view.
Why These Changes Matter: