Apache poi various smaller changes #12725
Open
+58
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
centic9
commented
Nov 17, 2024
•
centic9
commented
- Update JDK 8 and 11 to latest patch-levels
- Add temporary work around for invalid dependency on log4j-bom introduced via recent XmlBeans
- Fix presubmit-checks for Apache POI
- Print out which file fails checks in presubmit.py to aid in finding the culprit
|
centic9 has previously contributed to projects/apache-poi. The previous PR was #12589 |
centic9
force-pushed
the
apache_poi_various_smaller_changes
branch
from
e263050 to
6411987
Compare
…ntroduced via recent XmlBeans Add Apache Staging repository This is needed as sometimes an unreleased XmlBeans is used Exclude invalid bom-dependency and replace it with the proper one Use latest log4j to avoid issue apache/logging-log4j2#3196
Otherwise it is hard to find out which Dockerfile actually failed the checks.
Add apt-get update before apt-get install to make presubmit.py succeed again.
centic9
force-pushed
the
apache_poi_various_smaller_changes
branch
from
6411987 to
3f581b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.