Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: go1.20.11
Choose a base ref
...
head repository: golang/go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: go1.20.12
Choose a head ref
  • 8 commits
  • 10 files changed
  • 5 contributors

Commits on Nov 7, 2023

  1. [release-branch.go1.20] cmd/go/internal/modfetch/codehost: set core.l…

    …ongpaths in Git repos on Windows
    
    This setting appears to be needed to avoid “Filename too long” errors
    when downloading modules from repos with long branch names,
    particularly if the path to the module cache is already fairly long
    (as may be the case in CI systems and in tests of cmd/go itself).
    
    Fixes #63988.
    
    Change-Id: I3aa89ea872b29eb0460c8a8afc94f182a68982fd
    Reviewed-on: https://go-review.googlesource.com/c/go/+/482819
    Reviewed-by: Russ Cox <[email protected]>
    Reviewed-by: Heschi Kreinick <[email protected]>
    Run-TryBot: Bryan Mills <[email protected]>
    Auto-Submit: Bryan Mills <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    (cherry picked from commit 0c89487)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/539278
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Bryan C. Mills authored and heschi committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    e1dc209 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. [release-branch.go1.20] cmd/go/internal/vcs: error out if the request…

    …ed repo does not support a secure protocol
    
    Updates #63845.
    Fixes #63972.
    
    Change-Id: If86d6b13d3b55877b35c087112bd76388c9404b8
    Reviewed-on: https://go-review.googlesource.com/c/go/+/539321
    Reviewed-by: Michael Matloob <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: Roland Shoemaker <[email protected]>
    Auto-Submit: Bryan Mills <[email protected]>
    (cherry picked from commit be26ae1)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/540335
    Auto-Submit: Dmitri Shuralyov <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Bryan C. Mills authored and gopherbot committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    46bc338 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. [release-branch.go1.20] path/filepath: consider \\?\c: as a volume on…

    … Windows
    
    While fixing several bugs in path handling on Windows,
    beginning with \\?\.
    
    Prior to #540277, VolumeName considered the first path component
    after the \\?\ prefix to be part of the volume name.
    After, it considered only the \\? prefix to be the volume name.
    
    Restore the previous behavior.
    
    For #64028.
    Fixes #64040.
    
    Change-Id: I6523789e61776342800bd607fb3f29d496257e68
    Reviewed-on: https://go-review.googlesource.com/c/go/+/541175
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: Roland Shoemaker <[email protected]>
    (cherry picked from commit eda42f7)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/541520
    Auto-Submit: Dmitri Shuralyov <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Run-TryBot: Dmitri Shuralyov <[email protected]>
    Reviewed-by: Damien Neil <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    neild authored and gopherbot committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    1b59b01 View commit details
    Browse the repository at this point in the history
  2. [release-branch.go1.20] crypto/rand,runtime: switch RtlGenRandom for …

    …ProcessPrng
    
    RtlGenRandom is a semi-undocumented API, also known as
    SystemFunction036, which we use to generate random data on Windows.
    It's definition, in cryptbase.dll, is an opaque wrapper for the
    documented API ProcessPrng. Instead of using RtlGenRandom, switch to
    using ProcessPrng, since the former is simply a wrapper for the latter,
    there should be no practical change on the user side, other than a minor
    change in the DLLs we load.
    
    Updates #53192
    Fixes #64412
    
    Change-Id: Ie6891bf97b1d47f5368cccbe92f374dba2c2672a
    Reviewed-on: https://go-review.googlesource.com/c/go/+/536235
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: Quim Muntal <[email protected]>
    Auto-Submit: Roland Shoemaker <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    (cherry picked from commit 693def1)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/545356
    Auto-Submit: Dmitri Shuralyov <[email protected]>
    rolandshoemaker authored and gopherbot committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    1bd7657 View commit details
    Browse the repository at this point in the history
  3. [release-branch.go1.20] cmd/compile: fix findIndVar so it does not ma…

    …tch disjointed loop headers
    
    Fix #63983
    
    parseIndVar, prove and maybe more are on the assumption that the loop header
    is a single block. This can be wrong, ensure we don't match theses cases we
    don't know how to handle.
    
    In the future we could update them so that they know how to handle such cases
    but theses cases seems rare so I don't think the value would be really high.
    We could also run a loop canonicalization pass first which could handle this.
    
    The repro case looks weird because I massaged it so it would crash with the
    previous compiler.
    
    Change-Id: I4aa8afae9e90a17fa1085832250fc1139c97faa6
    Reviewed-on: https://go-review.googlesource.com/c/go/+/539977
    Reviewed-by: Heschi Kreinick <[email protected]>
    Reviewed-by: Keith Randall <[email protected]>
    Reviewed-by: Keith Randall <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    (cherry picked from commit 8b4e125)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/539936
    Run-TryBot: Dmitri Shuralyov <[email protected]>
    Reviewed-by: Mauri de Souza Meneguzzo <[email protected]>
    TryBot-Bypass: Dmitri Shuralyov <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Reviewed-by: Jorropo <[email protected]>
    Reviewed-by: Michael Knyszek <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Auto-Submit: Dmitri Shuralyov <[email protected]>
    Jorropo authored and gopherbot committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    d77307f View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. [release-branch.go1.20] crypto/rand,runtime: revert "switch RtlGenRan…

    …dom for ProcessPrng"
    
    This reverts CL 545356.
    
    Reason for revert: 1.20 still supports Windows versions before
    ProcessPrng was introduced.
    
    Change-Id: I224b8c4e7d0ca9ad5e733819b24dd92d14e61ab8
    Reviewed-on: https://go-review.googlesource.com/c/go/+/545995
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    TryBot-Bypass: Dmitri Shuralyov <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Run-TryBot: Dmitri Shuralyov <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Auto-Submit: Dmitri Shuralyov <[email protected]>
    rolandshoemaker authored and gopherbot committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    77397ff View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. [release-branch.go1.20] net/http: limit chunked data overhead

    The chunked transfer encoding adds some overhead to
    the content transferred. When writing one byte per
    chunk, for example, there are five bytes of overhead
    per byte of data transferred: "1\r\nX\r\n" to send "X".
    
    Chunks may include "chunk extensions",
    which we skip over and do not use.
    For example: "1;chunk extension here\r\nX\r\n".
    
    A malicious sender can use chunk extensions to add
    about 4k of overhead per byte of data.
    (The maximum chunk header line size we will accept.)
    
    Track the amount of overhead read in chunked data,
    and produce an error if it seems excessive.
    
    Updates #64433
    Fixes #64434
    Fixes CVE-2023-39326
    
    Change-Id: I40f8d70eb6f9575fb43f506eb19132ccedafcf39
    Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/2076135
    Reviewed-by: Tatiana Bradley <[email protected]>
    Reviewed-by: Roland Shoemaker <[email protected]>
    (cherry picked from commit 3473ae72ee66c60744665a24b2fde143e8964d4f)
    Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/2095407
    Run-TryBot: Roland Shoemaker <[email protected]>
    TryBot-Result: Security TryBots <[email protected]>
    Reviewed-by: Damien Neil <[email protected]>
    Reviewed-on: https://go-review.googlesource.com/c/go/+/547355
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    neild authored and cagedmantis committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    6446af9 View commit details
    Browse the repository at this point in the history
  2. [release-branch.go1.20] go1.20.12

    Change-Id: I79ae17037f1b4a126d9ca04106b7943c0961d967
    Reviewed-on: https://go-review.googlesource.com/c/go/+/547435
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: Carlos Amedee <[email protected]>
    Auto-Submit: Gopher Robot <[email protected]>
    gopherbot committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    97c8ff8 View commit details
    Browse the repository at this point in the history
Loading