-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion to change json parser in order to improve performance #76
Comments
Thank you for your suggestion. I will have a look. |
@ZandorZ I have done my analysis. json-iterator supports all three compliant methods
There are other two candid libraries are available: ffjson supports two compliant methods
easyjson but this one is doesn't support drop-in replacement, so out-of-choice. So, following is my design choice/approach:
For example developer can register like this- // For default client
resty.DefaultClient.JSONMarshal = jsoniter.Marshal
resty.DefaultClient.JSONUnmarshal = jsoniter.Unmarshal
// For custom client
myclient := resty.New()
myclient.JSONMarshal = jsoniter.Marshal
myclient.JSONUnmarshal = jsoniter.Unmarshal I will give it try on the implementation and will post the outcome. Do you have any suggestions? |
I have implemented above mentioned design e621018, it is not yet merged to master. |
@jeevatkm Good idea! |
Merging e621018 into master. |
Merged to master |
Instead of using standard encoding/json, maybe use another like https://github.com/json-iterator/go
The text was updated successfully, but these errors were encountered: