Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign Pull Requests with induvidual keys #22100

Open
gernotpokorny opened this issue Dec 11, 2022 · 0 comments
Open

Sign Pull Requests with induvidual keys #22100

gernotpokorny opened this issue Dec 11, 2022 · 0 comments
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@gernotpokorny
Copy link

gernotpokorny commented Dec 11, 2022

Feature Description

At the moment it is possible to automatically sign a resulting merge commit of a pull request via configuring Gitea like mentioned here. The problem with that is, that this will always lead to the same signature provided by the server and it is not possible at the moment for Collaborators to sign the resulting merge commit themselves (at least I found no options to do that).

To me it seems that this current way to sign the resulting merge commits of a pull request is more a workaround to make it possible to have the "Require Signed Commits" setting enabled, but it does not really add much value.

At the end of the day a resulting merge commit of a pull request should ideally be also signable by an individual like other commits.

I do not have that much insight on how the signing process works in git, but wouldn't is be possible to output the commit in the UI and demand it to be signed via Kleopatra or some other gpg frontend and then the user provides the signed commit as a response in the UI?

Screenshots

No response

@gernotpokorny gernotpokorny added type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Dec 11, 2022
@lunny lunny removed the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests

2 participants