Fixes gremlin where changing step and direction inversion masks made a mess #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctly because step_port_invert_mask[] (new with the RAMPS modifications) wasn't reset to 0 when it should have been. this made a mess.
|
Thanks. |
|
No problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a gremlin where changing the stepper step and direction inversion masks didn't work correctly because step_port_invert_mask[] and dir_port_invert_mask[] (new with the RAMPS modifications) weren't reset to 0 when they should have been (when unset).
This made initial setup more difficult due to likely desynchronization between settings.step_invert_mask and step_port_invert_mask[] and between settings.dir_invert_mask and dir_port_invert_mask[] with a change to $2 or $3, where grbl would ultimately behave as though there was always an inversion.
(Also, while I might have used a ternary to fix this, the way I did it seemed most consistent with grbl style. Please advise if you'd rather a ternary - easy fix.)