fix: #226 #227
Merged
fix: #226 #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjbassi
reviewed
Feb 22, 2019
|
Thanks for these fixes. Looks good and it works for me, just got a couple of questions/suggestions about some implementation details. |
|
I was looking for exactly this fix! Tried it out locally, and it seemed to work. Thanks! |
|
Done the change, please check it again later. Thx. |
cjbassi
added a commit
that referenced
this pull request
Feb 24, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed unicode string display issue in widgets paragraph, table and list. I'm not sure am I fix all of them.