integration test fail fast (#94)

sgoedecke · web-flow · commit f38cd97dc041 · 2025-08-04T20:52:25.000+10:00
diff --git a/Makefile b/Makefile
@@ -16,7 +16,7 @@ ci-lint:
 	golangci-lint run --timeout 5m ./...
 .PHONY: ci-lint
 
-integration: build
+integration: check build
 	@echo "==> running integration tests <=="
 	cd integration && go mod tidy && go test -v -timeout=5m
 .PHONY: integration
diff --git a/integration/integration_test.go b/integration/integration_test.go
@@ -12,7 +12,7 @@ import (
 )
 
 const (
-	binaryName      = "gh-models-test"
+	binaryName      = "gh-models"
 	timeoutDuration = 30 * time.Second
 )
 
@@ -26,7 +26,7 @@ func getBinaryPath(t *testing.T) string {
 
 	// Check if binary exists
 	if _, err := os.Stat(binaryPath); os.IsNotExist(err) {
-		t.Skipf("Binary %s not found. Run 'script/build' first.", binaryPath)
+		t.Fatalf("Binary %s not found. Run 'script/build' first.", binaryPath)
 	}
 
 	return binaryPath
@@ -87,15 +87,15 @@ func TestList(t *testing.T) {
 // TestRun tests the run command with a simple prompt
 // This test is more limited since it requires actual model inference
 func TestRun(t *testing.T) {
-	stdout, _, err := runCommand(t, "run", "openai/gpt-4.1-nano", "say 'pain' in french")
+	stdout, _, err := runCommand(t, "run", "openai/gpt-4.1-nano", "say 'bread' in french")
 	require.NoError(t, err, "Run should work")
 	require.Contains(t, strings.ToLower(stdout), "pain")
 }
 
 // TestIntegrationRunWithOrg tests the run command with --org flag
 func TestRunWithOrg(t *testing.T) {
 	// Test run command with --org flag (using help to avoid expensive API calls)
-	stdout, _, err := runCommand(t, "run", "openai/gpt-4.1-nano", "say 'pain' in french", "--org", "github")
+	stdout, _, err := runCommand(t, "run", "openai/gpt-4.1-nano", "say 'bread' in french", "--org", "github")
 	require.NoError(t, err, "Run should work")
 	require.Contains(t, strings.ToLower(stdout), "pain")
 }

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ import (`
`12`	`12`	`)`
`13`	`13`
`14`	`14`	`const (`
`15`		`- binaryName = "gh-models-test"`
	`15`	`+ binaryName = "gh-models"`
`16`	`16`	`timeoutDuration = 30 * time.Second`
`17`	`17`	`)`
`18`	`18`
`@@ -26,7 +26,7 @@ func getBinaryPath(t *testing.T) string {`
`26`	`26`
`27`	`27`	`// Check if binary exists`
`28`	`28`	`if _, err := os.Stat(binaryPath); os.IsNotExist(err) {`
`29`		`- t.Skipf("Binary %s not found. Run 'script/build' first.", binaryPath)`
	`29`	`+ t.Fatalf("Binary %s not found. Run 'script/build' first.", binaryPath)`
`30`	`30`	`}`
`31`	`31`
`32`	`32`	`return binaryPath`
`@@ -87,15 +87,15 @@ func TestList(t *testing.T) {`
`87`	`87`	`// TestRun tests the run command with a simple prompt`
`88`	`88`	`// This test is more limited since it requires actual model inference`
`89`	`89`	`func TestRun(t *testing.T) {`
`90`		`- stdout, _, err := runCommand(t, "run", "openai/gpt-4.1-nano", "say 'pain' in french")`
	`90`	`+ stdout, _, err := runCommand(t, "run", "openai/gpt-4.1-nano", "say 'bread' in french")`
`91`	`91`	`require.NoError(t, err, "Run should work")`
`92`	`92`	`require.Contains(t, strings.ToLower(stdout), "pain")`
`93`	`93`	`}`
`94`	`94`
`95`	`95`	`// TestIntegrationRunWithOrg tests the run command with --org flag`
`96`	`96`	`func TestRunWithOrg(t *testing.T) {`
`97`	`97`	`// Test run command with --org flag (using help to avoid expensive API calls)`
`98`		`- stdout, _, err := runCommand(t, "run", "openai/gpt-4.1-nano", "say 'pain' in french", "--org", "github")`
	`98`	`+ stdout, _, err := runCommand(t, "run", "openai/gpt-4.1-nano", "say 'bread' in french", "--org", "github")`
`99`	`99`	`require.NoError(t, err, "Run should work")`
`100`	`100`	`require.Contains(t, strings.ToLower(stdout), "pain")`
`101`	`101`	`}`