Skip to content

Commit 78b652d

Browse files
Copilotpelikhan
andcommitted
Address feedback: add build target, update workflow, and simplify
Co-authored-by: pelikhan <[email protected]>
1 parent d2bf593 commit 78b652d

File tree

3 files changed

+9
-20
lines changed

3 files changed

+9
-20
lines changed

.github/workflows/integration.yml

Lines changed: 3 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ on:
88

99
permissions:
1010
contents: read
11+
models: read
1112

1213
concurrency:
1314
group: ${{ github.workflow }}-${{ github.ref }}
@@ -30,7 +31,7 @@ jobs:
3031
check-latest: true
3132

3233
- name: Build gh-models binary
33-
run: script/build
34+
run: make build
3435

3536
- name: Run integration tests (without auth)
3637
working-directory: integration
@@ -40,21 +41,4 @@ jobs:
4041
env:
4142
# Explicitly unset any GitHub tokens to test unauthenticated behavior
4243
GITHUB_TOKEN: ""
43-
GH_TOKEN: ""
44-
45-
- name: Install gh CLI
46-
if: github.event_name == 'workflow_dispatch'
47-
run: |
48-
curl -fsSL https://cli.github.com/packages/githubcli-archive-keyring.gpg | sudo dd of=/usr/share/keyrings/githubcli-archive-keyring.gpg
49-
echo "deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/githubcli-archive-keyring.gpg] https://cli.github.com/packages stable main" | sudo tee /etc/apt/sources.list.d/github-cli.list > /dev/null
50-
sudo apt update
51-
sudo apt install gh
52-
53-
- name: Run integration tests (with auth)
54-
if: github.event_name == 'workflow_dispatch'
55-
working-directory: integration
56-
run: |
57-
gh auth login --with-token <<< "${{ secrets.GITHUB_TOKEN }}"
58-
go test -v -timeout=10m
59-
env:
60-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
44+
GH_TOKEN: ""

DEV.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ In addition to unit tests, we have integration tests that use the compiled binar
4040

4141
```shell
4242
# Build the binary first
43-
script/build
43+
make build
4444

4545
# Run integration tests
4646
cd integration

Makefile

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
check: fmt vet tidy test
22
.PHONY: check
33

4+
build:
5+
@echo "==> building gh-models binary <=="
6+
script/build
7+
.PHONY: build
8+
49
fmt:
510
@echo "==> running Go format <=="
611
gofmt -s -l -w .

0 commit comments

Comments
 (0)