Skip to content

Commit 0446cb0

Browse files
address comments
1 parent 29cf065 commit 0446cb0

File tree

6 files changed

+14
-10
lines changed

6 files changed

+14
-10
lines changed

lib/config-utils.test.js

Lines changed: 4 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/config-utils.test.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/testing-utils.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/testing-utils.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/config-utils.test.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ test("default queries are used", async t => {
206206
process.env['GITHUB_WORKSPACE'] = tmpDir;
207207

208208
// Check that the default behaviour is to add the default queries.
209-
// In this case if a config file is specified by does not include
209+
// In this case if a config file is specified but does not include
210210
// the disable-default-queries field.
211211
// We determine this by whether CodeQL.resolveQueries is called
212212
// with the correct arguments.
@@ -225,7 +225,9 @@ test("default queries are used", async t => {
225225
},
226226
});
227227

228-
// Just create a generic config object with non-default values for all fields
228+
// The important point of this config is that is doesn't specify
229+
// the disable-default-queries field.
230+
// Any other details are hopefully irrelevant for this tetst.
229231
const inputFileContents = `
230232
paths:
231233
- foo`;

src/testing-utils.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,10 @@ export function setupTests(test: TestInterface<any>) {
5151
process.stderr.write = wrapOutput(t.context) as any;
5252

5353
// Many tests modify environment variables. Take a copy now so that
54-
// We reset them after the test to keep tests independent of each other.
54+
// we reset them after the test to keep tests independent of each other.
5555
// process.env only has strings fields, so a shallow copy is fine.
5656
t.context.env = {};
57-
Object.assign(process.env, t.context.env);
57+
Object.assign(t.context.env, process.env);
5858
});
5959

6060
typedTest.afterEach.always(t => {

0 commit comments

Comments
 (0)