Python: Fix broken queries

tausbn · tausbn · commit 6ebaff3fdd7f · 2025-12-05T13:48:28.000Z
diff --git a/python/ql/lib/analysis/DefinitionTracking.qll b/python/ql/lib/analysis/DefinitionTracking.qll
@@ -471,11 +471,10 @@ Definition getUniqueDefinition(Expr use) {
   not result = TLocalDefinition(use)
 }
 
-/** A helper class to get suitable locations for attributes */
-class NiceLocationExpr extends Expr {
-  /** Gets a textual representation of this element. */
-  override string toString() { result = this.(Expr).toString() }
+final class FinalExpr = Expr;
 
+/** A helper class to get suitable locations for attributes */
+class NiceLocationExpr extends FinalExpr {
   /**
    * Holds if this element is at the specified location.
    * The location spans column `bc` of line `bl` to
diff --git a/python/ql/src/Variables/LoopVariableCapture/LoopVariableCaptureQuery.qll b/python/ql/src/Variables/LoopVariableCapture/LoopVariableCaptureQuery.qll
@@ -3,8 +3,10 @@
 import python
 import semmle.python.dataflow.new.DataFlow
 
+final class FinalAstNode = AstNode;
+
 /** A looping construct. */
-abstract class Loop extends AstNode {
+abstract class Loop extends FinalAstNode {
   /**
    * Gets a loop variable of this loop.
    * For example, `x` and `y` in `for x,y in pairs: print(x+y)`
@@ -13,9 +15,9 @@ abstract class Loop extends AstNode {
 }
 
 /** A `for` loop. */
-private class ForLoop extends Loop, For {
+private class ForLoop extends Loop instanceof For {
   override Variable getALoopVariable() {
-    this.getTarget() = result.getAnAccess().getParentNode*() and
+    this.(For).getTarget() = result.getAnAccess().getParentNode*() and
     result.getScope() = this.getScope()
   }
 }
diff --git a/python/ql/src/analysis/ImportFailure.ql b/python/ql/src/analysis/ImportFailure.ql
@@ -59,7 +59,9 @@ predicate ok_to_fail(ImportExpr ie) {
   os_specific_import(ie) != get_os()
 }
 
-class VersionTest extends ControlFlowNode {
+final class FinalControlFlowNode = ControlFlowNode;
+
+class VersionTest extends FinalControlFlowNode {
   VersionTest() {
     exists(string name |
       name.matches("%version%") and
@@ -70,7 +72,7 @@ class VersionTest extends ControlFlowNode {
     )
   }
 
-  override string toString() { result = "VersionTest" }
+  string toString() { result = "VersionTest" }
 }
 
 /** A guard on the version of the Python interpreter */

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,9 @@ predicate ok_to_fail(ImportExpr ie) {`
`59`	`59`	`os_specific_import(ie) != get_os()`
`60`	`60`	`}`
`61`	`61`
`62`		`-class VersionTest extends ControlFlowNode {`
	`62`	`+final class FinalControlFlowNode = ControlFlowNode;`
	`63`	`+`
	`64`	`+class VersionTest extends FinalControlFlowNode {`
`63`	`65`	`VersionTest() {`
`64`	`66`	`exists(string name \|`
`65`	`67`	`name.matches("%version%") and`
`@@ -70,7 +72,7 @@ class VersionTest extends ControlFlowNode {`
`70`	`72`	`)`
`71`	`73`	`}`
`72`	`74`
`73`		`- override string toString() { result = "VersionTest" }`
	`75`	`+ string toString() { result = "VersionTest" }`
`74`	`76`	`}`
`75`	`77`
`76`	`78`	`/** A guard on the version of the Python interpreter */`