Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git LFS does not cache tokens from git-lfs-authenticate #5797

Open
TACIXAT opened this issue Jun 10, 2024 · 1 comment
Open

Git LFS does not cache tokens from git-lfs-authenticate #5797

TACIXAT opened this issue Jun 10, 2024 · 1 comment
Labels
enhancement

Comments

@TACIXAT
Copy link

TACIXAT commented Jun 10, 2024

Describe the issue
Basically what it says in the title. I implemented a minimal Git LFS server and authentication binary. I set a limit of 10 tokens per 24 hours from the authentication binary expecting Git LFS to cache the tokens and reuse them. Instead it fetches a new one for every operation.

System environment
Windows host.

Output of git lfs env

git-lfs/3.4.0 (GitHub; windows amd64; go 1.20.6; git d06d6e9e)
git version 2.43.0.windows.1

Endpoint=https://github.com/work/project.git/info/lfs (auth=basic)
LocalWorkingDir=C:\Users\name\Documents\Development\project
LocalGitDir=C:\Users\name\Documents\Development\project\.git
LocalGitStorageDir=C:\Users\name\Documents\Development\project\.git
LocalMediaDir=C:\Users\name\Documents\Development\project\.git\lfs\objects
LocalReferenceDirs=
TempDir=C:\Users\name\Documents\Development\project\.git\lfs\tmp
ConcurrentTransfers=8
TusTransfers=false
BasicTransfersOnly=false
SkipDownloadErrors=false
FetchRecentAlways=false
FetchRecentRefsDays=7
FetchRecentCommitsDays=0
FetchRecentRefsIncludeRemotes=true
PruneOffsetDays=3
PruneVerifyRemoteAlways=false
PruneRemoteName=origin
LfsStorageDir=C:\Users\name\Documents\Development\project\.git\lfs
AccessDownload=basic
AccessUpload=basic
DownloadTransfers=basic,lfs-standalone-file,ssh
UploadTransfers=basic,lfs-standalone-file,ssh
GIT_EXEC_PATH=C:/Program Files/Git/mingw64/libexec/git-core
git config filter.lfs.process = "git-lfs filter-process"
git config filter.lfs.smudge = "git-lfs smudge -- %f"
git config filter.lfs.clean = "git-lfs clean -- %f"
@bk2204
Copy link
Member

bk2204 commented Jun 11, 2024

Hey,

Thanks for the report. I believe we do actually cache tokens, but on a per-thread basis. That being said, I think there's some improvements we could make here, and this report is actually very similar to #5784. I'll mark it as an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bk2204 @TACIXAT