fix(ssh): use /tmp to place control dir on darwin

aymanbagabas · aymanbagabas · commit 83fdf8efd536 · 2022-12-18T12:16:32.000+03:00
OpenSSH complains if the control path is too long (&gt;=104)
On Darwin, os.MkdirTemp is too long, use /tmp instead.

ControlPath too long ('/var/folders/v3/5pnzpycs0pzdpytmgfzc7tj80000gn/T/sock-96855798/sock-b677e145501e220cfb5583ba1638a77ffe779df9' &gt;= 104 bytes)

Signed-off-by: Ayman Bagabas &lt;ayman.bagabas@gmail.com&gt;
diff --git a/ssh/ssh.go b/ssh/ssh.go
@@ -2,10 +2,10 @@ package ssh
 
 import (
 	"fmt"
-	"io/ioutil"
 	"os"
 	"path/filepath"
 	"regexp"
+	"runtime"
 	"strings"
 	"syscall"
 
@@ -110,9 +110,14 @@ func findRuntimeDir(osEnv config.Environment) string {
 }
 
 func getControlDir(osEnv config.Environment) (string, error) {
+	tmpdir, pattern := "", "sock-*"
+	if runtime.GOOS == "darwin" {
+		// On Darwin, the default temporary directory results in a socket path that's too long.
+		tmpdir = "/tmp"
+	}
 	dir := findRuntimeDir(osEnv)
 	if dir == "" {
-		return ioutil.TempDir("", "sock-*")
+		return os.MkdirTemp(tmpdir, pattern)
 	}
 	dir = filepath.Join(dir, "git-lfs")
 	err := os.Mkdir(dir, 0700)
@@ -121,7 +126,7 @@ func getControlDir(osEnv config.Environment) (string, error) {
 		// os.ErrExist, but that's not available on Go 1.11.
 		perr, ok := err.(*os.PathError)
 		if !ok || perr.Err != syscall.EEXIST {
-			return ioutil.TempDir("", "sock-*")
+			return os.MkdirTemp(tmpdir, pattern)
 		}
 	}
 	return dir, nil
