Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown: Allow configuring which links are safe to keep in the user content #1089

Open
onionltd opened this issue Aug 17, 2022 · 1 comment

Comments

@onionltd
Copy link
Contributor

gomarkdown allows adding items to the list of URLs which are safe to convert to HTML links. By default gomarkdown supports http(s)://, ftp://, and mailto:. I'm wondering what would be the best way to implement adding more from within the configuration file.

@onionltd
Copy link
Contributor Author

onionltd commented Sep 5, 2022

I patched fider's markdown package so it consumes ENV variables, and then patched the configuration structs so it accepts a list of values - URIs. However, I later found that markdown rendering is handled by the frontend application and not the backend, except for the parts which deal with notifications and emails content.

I don't much understand the decision to have a markdown renderer on the frontend instead of just accepting already rendered content in form of HTML, but it is what it is. I wonder what's the best way to move forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant