Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and refactor simple validation #2682

Closed
mbastian opened this issue Nov 2, 2022 · 1 comment
Closed

Update and refactor simple validation #2682

mbastian opened this issue Nov 2, 2022 · 1 comment
Assignees
Labels
UI Wishlist New features (not a bug)
Milestone

Comments

@mbastian
Copy link
Member

mbastian commented Nov 2, 2022

We still rely on a simple-validation JAR that's on our 3rd party MVN repository. ValidationAPI is used in a lot of UI modules and it's not up-to-date.

Proposed solution

Use the one coming from NB module.

Alternatives considered

Anything that's on Maven central.

Additional context

Codebase is here: https://github.com/timboudreau/simplevalidation

@mbastian mbastian added Wishlist New features (not a bug) UI labels Nov 2, 2022
@mbastian mbastian added this to the 0.10.0 milestone Nov 2, 2022
@mbastian
Copy link
Member Author

mbastian commented Nov 5, 2022

It was too cumbersome to use the NB module as it belongs to the IDE cluster and doesn't have public packages. I went with the official Maven dependency instead

<dependency>
    <groupId>com.mastfrog</groupId>
    <artifactId>simplevalidation-swing</artifactId>
    <version>1.14.1</version>
    <exclusions>
        <exclusion>
            <groupId>com.mastfrog</groupId>
            <artifactId>nbstubs</artifactId>
        </exclusion>
    </exclusions>
</dependency>

The library is part of the UILibraryWrapper module and exposes the API via public packages. I also wrote a small wrapper DialogDescriptorWithValidation to make it easy to work with DialogDescriptor that contains ValidationPanel as inner panel.

@mbastian mbastian self-assigned this Nov 5, 2022
@mbastian mbastian closed this as completed Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI Wishlist New features (not a bug)
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant