You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Neither a bug, nor a feature request, more an improvement. I will maybe do a PR myself, but gotta get than assignment done first...
Expected Behavior
all *DegreeRangeBuilders should return corresponding types, when getFilter() is called.
Current Behavior
The OutDegreeRangeBuilder returns a generic Object of interface type Filter, InDegreeRangeBuilder and DegreeRangeBuilder return the specialized internal object InDegreeRangeFilter and DegreeRangeFilter respectively.
Possible Solution
all three should probably return a RangeFilter and the setRange() method should be declared in that interface and overwritten in DegreeRangeFilter, InDegreeRangeFilter and OutDegreeRangeFilter
Steps to Reproduce
var f1 = new OutDegreeRangeBuilder.getFilter() // returns a Filter
var f2 = new InDegreeRangeBuilder.getFilter() // returns a InDegreeRangeFilter
var f3 = new DegreeRangeBuilder.getFilter() // returns a DegreeRangeFilter
Context
when using the gephi-toolkit with there filters, one has to cast the result of OutDegreeRangeFilter.getFilter() to set the range.
Your Environment
Version used: Gephi 0.9.7
Operating System: Win 10 21H2
Java 11
The text was updated successfully, but these errors were encountered:
Thanks I fixed this one. The reason we don't expose setRange int he RangeFilter interface I think is to avoid direct edition of the range value. The correct way is to pass through the FilterProperty normally. I don't think it matters for Toolkit users though but int he Gephi UI, if you would use setRange directly the UI wouldn't update.
Neither a bug, nor a feature request, more an improvement. I will maybe do a PR myself, but gotta get than assignment done first...
Expected Behavior
all
*DegreeRangeBuilders
should return corresponding types, whengetFilter()
is called.Current Behavior
The
OutDegreeRangeBuilder
returns a generic Object of interface typeFilter
,InDegreeRangeBuilder
andDegreeRangeBuilder
return the specialized internal objectInDegreeRangeFilter
andDegreeRangeFilter
respectively.Possible Solution
all three should probably return a
RangeFilter
and thesetRange()
method should be declared in that interface and overwritten inDegreeRangeFilter
,InDegreeRangeFilter
andOutDegreeRangeFilter
Steps to Reproduce
Context
when using the gephi-toolkit with there filters, one has to cast the result of
OutDegreeRangeFilter.getFilter()
to set the range.Your Environment
The text was updated successfully, but these errors were encountered: