Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DisplayVersion not populated when installing on Windows #2575

Closed
asjimene opened this issue Jul 29, 2022 · 2 comments
Closed

DisplayVersion not populated when installing on Windows #2575

asjimene opened this issue Jul 29, 2022 · 2 comments

Comments

@asjimene
Copy link

asjimene commented Jul 29, 2022

Expected Behavior

DisplayVersion should be recorded in the Windows registry when installing Gephi.

Current Behavior

DisplayVersion is not set in the Windows registry when installing Gephi

Possible Solution

It seems that InnoSetup is being used to build this installer, InnoSetup should put the DisplayVersion in the Windows registry as long as it is specified in the setup file: https://jrsoftware.org/ishelp/index.php?topic=setup_appversion

I do believe AppVersion just needs to be added to this file: https://github.com/gephi/gephi/blob/master/modules/application/src/main/app-resources/gephi.iss

Steps to Reproduce

  1. Install Gephi on a Windows device
  2. Navigate to HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall{51722911-C391-4118-97BF-B50100D2AB15}_is1 (this is the path on the latest snapshot)
  3. The standard DisplayVersion registry value is missing

image

Context

DisplayName and DisplayVersion registry values are useful for detection when deploying software to an enterprise. They also help with software inventory in general. It is Microsoft best practices to include the DisplayName and DisplayVersion when installing software on Windows Operating Systems. https://docs.microsoft.com/en-us/windows/win32/msi/uninstall-registry-key

Your Environment

  • Version used: Gephi 0.9.7-snapshot (64-bit)
  • Operating System: Windows 10
@mbastian mbastian self-assigned this Aug 3, 2022
@mbastian mbastian added this to the 0.9.7 milestone Aug 3, 2022
@mbastian
Copy link
Member

mbastian commented Aug 3, 2022

Hi @asjimene and thanks for the detailed report!

I've added the DisplayVersion thanks to your instructions. Please download the latest build at https://github.com/gephi/gephi#nightly-builds and let me know if it works as expected. Thanks!

@asjimene
Copy link
Author

asjimene commented Aug 3, 2022

This is perfect! Just tested it and thank you
RemoteDesktopManagerFree_jjhmKGAvRI
!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants