Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GraphML parser flags "graph" level attributes as an error. #1497

Closed
markharwood opened this issue May 27, 2016 · 3 comments
Closed

GraphML parser flags "graph" level attributes as an error. #1497

markharwood opened this issue May 27, 2016 · 3 comments
Assignees
@mbastian
Labels
GraphML
Milestone
0.9.6

Comments

@markharwood
Copy link

If a GraphML file declares an attribute for the type "graph" the code here flags a "severe" error in the load dialog
import report

Attributes in GraphML can be declared for node, edge, graph and all but this code throws an error if we pass an attrib of the type graph.

Tested the same GraphML file with Yed and it correctly parses and shows the different attributes grouped by node/edge/graph types:
custom properties

Example file:

<graphml>
    <key id="d0" for="node" attr.name="myNodeAttr" attr.type="string">
        <default>0</default>
    </key>
    <key id="d1" for="graph" attr.name="myGraphAttr" attr.type="string">
        <default>no value</default>
    </key>
    <graph edgedefault="undirected">
        <data key="d1">myGraphValue</data>
        <node id="myNodeId">
            <data key="d0">myNodeValue</data>
        </node>
    </graph>
</graphml>
@eduramiba
Copy link
Member

Hi,
Graph attributes are not supported in Gephi yet.

@eduramiba eduramiba self-assigned this Jul 7, 2017
@jthrilly
Copy link

Just wanted to flag up that I came across this today, too. Graph level attributes are currently used as a way to store metadata and ego level data by several softwares.

Can I suggest that the parser be updated to at least recognize the validity of the attribute according to the spec, thereby downgrading the issue level from 'severe' to 'info'. The accompanying message could say something like "Graph level attributes not supported currently".

@eduramiba - any implementation plan? I can provide a PR if the above proposal works for you.

@mbastian mbastian assigned mbastian and unassigned eduramiba May 14, 2022
@mbastian mbastian added this to the 0.9.6 milestone May 14, 2022
@mbastian
Copy link
Member

I added a warning instead of an error, indicating graph attributes are not recognised (yet).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbastian mbastian

Labels
GraphML
Projects
None yet
Milestone
0.9.6
Development

No branches or pull requests
4 participants
@markharwood @eduramiba @mbastian @jthrilly