Fix - add try/finally logic to wrap graph reentrant locks for layouts #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trajar
changed the title
|
Thank you for the pull request, we will review and merge this as soon as possible. |
eduramiba
added a commit
that referenced
this pull request
Nov 5, 2016
… logic to wrap graph reentrant locks for layouts
|
Merged in 4915870, thanks! |
eduramiba
added a commit
that referenced
this pull request
Nov 9, 2016
Based on commit ecbe7bf #1605 NullPointerException when no attribute is selected in Ranking or Partition #1469 Impossible to color arcs with a color gradient with 0.9.1 #1477 Import wizard 0.9.1 now showing any options #1487 Fix - add try/finally logic to wrap graph reentrant locks for layouts #1536 Add Edge dialog only remembers source index #1418 Import spreadsheet (csv) The id class does not match with the expected type #1387 Exception on ranking with column with null values #1612 Ranking min/max for uncommon types - UnsupportedOperationException: 'commlist' is not a sortable column (int[])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Graph layouts use graph read locks without proper try-catch logic as per the jdk documentation. When the layouts generate a runtime exception the result leaves the graph in a locked state, which then blocks all access threads (including swing/javafx).