Feature/db ignore unknown columns refactoring #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, K |
|
Thank you for the pull request, we will review and merge this as soon as possible. |
|
No problem, glad I can help.
|
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I see you've @mbastian fixed the issue I've stumbled upon in #1272 - when the column is not known, gephi database import threw an NPE.
I did a different fix - first, it's always good practice to compare the constant to the field, not the field to the constant, then no null check is necessary. E.g.
if (NodeProperty.ID.equals(foo))instead ofif (foo.equals(NodeProperty.ID)).That's the change I did first, but then I also refactored the code a bit - I think it's redundant to iterate over the column names for each result set iteration. Why not fetch the id column metadata first, and then use it?
Thats my suggestion here, please let me know what you think.
Cheers,
Kornel