Add warning message on import when opacity is always zero

mbastian · mbastian · commit fbdbc5ca5118 · 2022-01-23T14:06:37.000+01:00
diff --git a/modules/ImportAPI/src/main/java/org/gephi/io/importer/impl/ImportContainerImpl.java b/modules/ImportAPI/src/main/java/org/gephi/io/importer/impl/ImportContainerImpl.java
@@ -766,6 +766,10 @@ public boolean verify() {
                 .getMessage(ImportContainerImpl.class, "ImportContainerLog.MultiGraphCount", edgeTypeMap.size() - 1));
         }
 
+        //Check that not all alpha are zeros
+        checkColorAlpha(nodeList, "Node");
+        checkColorAlpha(edgeList, "Edge");
+
         return true;
     }
 
@@ -1085,6 +1089,25 @@ private EdgeDraftImpl getOpposite(EdgeDraftImpl edge) {
         return null;
     }
 
+    private void checkColorAlpha(ObjectList<? extends ElementDraft> objectList, String elementType) {
+        if (!objectList.isEmpty()) {
+            int validElement = 0;
+            int withAlphaZero = 0;
+            for (ElementDraft element : objectList) {
+                if (element.getColor() != null) {
+                    validElement++;
+                    withAlphaZero += element.getColor().getAlpha() == 0 ? 1 : 0;
+                }
+            }
+            if (validElement > 0 && validElement == withAlphaZero) {
+                report.logIssue(new Issue(
+                    NbBundle.getMessage(ImportContainerImpl.class,
+                        "ImportContainerException_" + elementType + "_Color_Alpha_AllZero"),
+                    Level.WARNING));
+            }
+        }
+    }
+
     private void checkElementDraftImpl(ElementDraft elmt) {
         if (elmt == null) {
             throw new NullPointerException();
diff --git a/modules/ImportAPI/src/main/resources/org/gephi/io/importer/impl/Bundle.properties b/modules/ImportAPI/src/main/resources/org/gephi/io/importer/impl/Bundle.properties
@@ -32,6 +32,8 @@ ImportContainerException_Negative_Weight = Edge id=''{0}'' has a negative weight
 ImportContainerException_Column_Type_Mismatch = A column ''{0}'' already exists but with a different type=''{1}''
 ImportContainerException_Timestamp_Parse_Error = The graph timestamp ''{0}'' could not be parsed
 ImportContainerException_Interval_Parse_Error = The graph interval ''{0}'' could not be parsed
+ImportContainerException_Node_Color_Alpha_AllZero = All nodes color opacity is set as transparent
+ImportContainerException_Edge_Color_Alpha_AllZero = All edges color opacity is set as transparent
 
 ElementFactoryException_NullNodeId = Node id can't be null
 ElementFactoryException_NullEdgeId = Edge id can't be null
