-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GEOS-11613] Increase control-flow logging admin visibility in logs #8045
base: main
Are you sure you want to change the base?
Conversation
82fd829
to
33a5103
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I have added a couple of questions.
<?xml version="1.0" encoding="UTF-8"?> | ||
<!-- This log4j configuration file needs to stay here, and is used as the default logging setup --> | ||
<!-- during data_dir upgrades and in case the chosen logging config isn't available. --> | ||
<Configuration name="PRODUCTION_LOGGING" status="fatal" dest="out"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a silly question: is it ok to have it named PRODUCTION_LOGGING or it would be better to name it CONTROL_FLOW_LOGGING?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think this shows up anywhere, but good point, best be consistent.
|
||
In this example: | ||
|
||
* A RateFlowController imposes a delay of 10 seconds on WPS andm WMS requests requests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't actually imposing a 1 second delay to the WMS request?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be clarified... WPS Is delayed 10000ms while WMS only 1000ms
* A concurrency control on wfs.getfeature with 8 requests is in place, with 3 executing. | ||
* A global concurrency control with 50 requests is in place, with 3 executing. | ||
* In summary, 3 requests are executing, and 12 are blocked. From this situation, they are queued on the single IP flow controller. | ||
* Looking at the timings, this request has been delayed for about 13 seconds on the single IP flow controller. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not very familiar with Control Flow:
why all the logs reports WFS 1.0.0 GetFeature? Is it because those details are reported when evaluating the status during that WFS getRequest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the same request being processed through all the configured controllers.
33a5103
to
bd5892c
Compare
See ticket for details
Checklist
main
branch (backports managed later; ignore for branch specific issues).For core and extension modules:
[GEOS-XYZWV] Title of the Jira ticket
.