Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: fsouza/fake-gcs-server
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.40.3
Choose a base ref
...
head repository: fsouza/fake-gcs-server
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.41.0
Choose a head ref
  • 4 commits
  • 16 files changed
  • 2 contributors

Commits on Oct 31, 2022

  1. Race-free Preconditions (#935) 

    * upload_test: Add UploadRacesAreOnlyWonByOne

This tests for race-conditions in Conditional uploads, by repeatedly
uploading to the same object from multiple go-routines, and verify that
only one succeeded.

* backend/storage:Add `Conditions` to CreateObject

Move the "Preconditions"-checking into the backend, to be done under the
protection of the backend mutex. This enables `DoesNotExist`-behavior to be
implemented race-free

* upload_test: improve diagostics of ..RacesAreOnlyWonByOne

* Apply suggestions from review

Co-authored-by: fsouza <[email protected]>

* upload_test:Use runServersTest in ...RacesAreOnlyWonByOne

While potentially a problem for test-performance, speed of running tests
are currently bearable on my machine

ok  	github.com/fsouza/fake-gcs-server	0.016s
ok  	github.com/fsouza/fake-gcs-server/fakestorage	1.176s
ok  	github.com/fsouza/fake-gcs-server/internal/backend	0.031s
ok  	github.com/fsouza/fake-gcs-server/internal/checksum	0.010s
ok  	github.com/fsouza/fake-gcs-server/internal/config	0.010s
ok  	github.com/fsouza/fake-gcs-server/internal/notification	0.026s

Co-authored-by: fsouza <[email protected]>
    @rawler @fsouza
    rawler and fsouza authored Oct 31, 2022
    Configuration menu
    Copy the full SHA
    4e828df View commit details
    Browse the repository at this point in the history

  2. Drop support for Windows

    @fsouza
    fsouza committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    b38adf6 View commit details
    Browse the repository at this point in the history

  3. Remove dependency on alexbrainman/goissue34681 

    Now that we no longer support Windows, that's no longer necessary.
    @fsouza
    fsouza committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    7524919 View commit details
    Browse the repository at this point in the history

  4. readme: add note about Windows support being dropped

    @fsouza
    fsouza committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    095cc2f View commit details
    Browse the repository at this point in the history
Loading