Skip to content

wait for single file analysis (update) #1252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jstucke merged 1 commit into from
Feb 4, 2025
Merged

wait for single file analysis (update) #1252

jstucke merged 1 commit into from
Feb 4, 2025

Conversation

@jstucke
Copy link
Collaborator

@jstucke jstucke commented Aug 29, 2024 •
edited
Loading

  • makes intercom backend listener "responder" asynchronous (so it does not block when waiting for the result)

  • converts the "single file analysis task" listener into a responder

  • changes the show analysis page so that single file analyses are awaited and the page is automatically reloaded

  • adds a button to the "analysis is outdated" message to quickly update it

  • based on intercom backend refactoring: make data flow comprehensible #1251 so that one should be merged first

@jstucke jstucke requested review from dorpvom and maringuu August 29, 2024 08:26
@jstucke jstucke self-assigned this Aug 29, 2024
@jstucke jstucke force-pushed the quick-update-outdated-analysis branch from b51d1e2 to a397a86 Compare August 29, 2024 08:28
@jstucke jstucke force-pushed the quick-update-outdated-analysis branch from a397a86 to c3fb840 Compare December 3, 2024 16:37
@jstucke jstucke marked this pull request as ready for review December 3, 2024 16:37
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 91.77%. Comparing base (635f62d) to head (9d27c2d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/intercom/back_end_binding.py 83.33% 4 Missing ⚠️
src/scheduler/analysis/scheduler.py 50.00% 4 Missing ⚠️
src/web_interface/components/analysis_routes.py 87.50% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1252      +/-   ##
==========================================
- Coverage   92.54%   91.77%   -0.78%     
==========================================
  Files         381      376       -5     
  Lines       24320    21088    -3232     
==========================================
- Hits        22508    19354    -3154     
+ Misses       1812     1734      -78

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jstucke jstucke force-pushed the quick-update-outdated-analysis branch from c3fb840 to 3af664e Compare January 9, 2025 10:59
euwint
euwint requested changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@euwint euwint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but when I run pytest in src/test/integration/intercom/, the test does not terminate. This is probably due to a threading problem

@jstucke jstucke force-pushed the quick-update-outdated-analysis branch from 3af664e to 099fa8c Compare February 3, 2025 14:37
@jstucke
feat(webinterface): wait for single file analysis
9d27c2d 
also adds a button to the 'analysis is outdated' message to update it
@jstucke jstucke force-pushed the quick-update-outdated-analysis branch from 099fa8c to 9d27c2d Compare February 3, 2025 14:37
@jstucke
Copy link
Collaborator Author

jstucke commented Feb 3, 2025 •
edited
Loading

Looks good, but when I run pytest in src/test/integration/intercom/, the test does not terminate. This is probably due to a threading problem

should hopefully be fixed now (see https://github.com/fkie-cad/FACT_core/compare/099fa8c63f711a4ccba0b993c3fd237818345d30..9d27c2d5606d6845a769deab7e18adf848a7d5dc)

euwint
euwint approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@euwint euwint left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem is fixed

@jstucke jstucke merged commit b977028 into master Feb 4, 2025
10 checks passed
@jstucke jstucke deleted the quick-update-outdated-analysis branch February 4, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@euwint euwint euwint approved these changes

@dorpvom dorpvom Awaiting requested review from dorpvom

@maringuu maringuu Awaiting requested review from maringuu

Assignees

@jstucke jstucke

Labels

feature gui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jstucke @codecov-commenter @euwint