broken commit: update internals of insert by period #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work on this one! Check out #320. I think we can still manage this as a patch release.
Which is a good thing!
Ideally the bash script would stop on the first error. We could maybe get this for free by adding |
…0-19 Fix: insert by period for 0.19
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jtcohen6 — this is what is broken, but I can't quite get it to work! not sure how to access the internals of the AdapterResponse class. Figured you would have a better idea than me :)
Also — this would be classed as a breaking change, so we might want to write some logic about handling this on different versions of dbt to avoid the break.
I was curious as to how this snuck in, and went back to #309 — turns out it silently failed back then! I think because the "test" step passed, even though the "run" step failed. Now that we are using
-x, the job exits, causing other tests to fail, and the resultant error message.I think the problem here is that we run the steps via the
run_test.shfile, when potentially we want them as separate (parameterized?) steps in the CircleCI workflow.