Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make expression_is_true test work as a column test #313

Merged
merged 3 commits into from
Dec 23, 2020
Merged

Conversation

clrcrl
Copy link
Contributor

@clrcrl clrcrl commented Dec 23, 2020

Opening in favor of #226

This is a:

  • bug fix PR with no breaking changes — please ensure the base branch is master
  • new functionality — please ensure the base branch is the latest dev/ branch
  • a breaking change — please ensure the base branch is the latest dev/ branch

Description & motivation

From #226:

I love the expression_is_true schema test, but often it feels like the tests I use them for should be a child of the column I'm testing against, instead of the whole relationship. So I modified the expression_is_true test to do exactly that.

Left the original tests as is (no regressions), and added 2 more tests to test with condition set and without it.

Checklist

  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

@clrcrl clrcrl merged commit 9490488 into dev/0.7.0 Dec 23, 2020
@clrcrl clrcrl deleted the pr/226 branch December 23, 2020 17:41
clrcrl pushed a commit that referenced this pull request May 18, 2021
clrcrl pushed a commit that referenced this pull request May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant