Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove errant default args from get_tables_by_pattern_sql #279

Merged
merged 2 commits into from
Sep 16, 2020
Merged

Remove errant default args from get_tables_by_pattern_sql #279

merged 2 commits into from
Sep 16, 2020

Conversation

clrcrl
Copy link
Contributor

@clrcrl clrcrl commented Sep 16, 2020 •
edited
Loading

This is a:

  • bug fix PR with no breaking changes (please change the base branch to main)
  • new functionality
  • a breaking change

Description & motivation

Turns out that this line forces the argument to be the default value.

Closes this issue on codegen

Testing

I updated my local version of codegen to also use my local version of utils, and tested locally.

I also did a quick cmf + f to find any other instances of this, and couldn't see anything — would definitely appreciate a second set of eyes there

Checklist

  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to the changelog

@clrcrl clrcrl mentioned this pull request Sep 16, 2020
Closed
5 tasks
@clrcrl clrcrl requested a review from jtcohen6 September 16, 2020 13:37
jtcohen6
jtcohen6 approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oof. good find

@clrcrl clrcrl merged commit dd35625 into master Sep 16, 2020
@clrcrl clrcrl deleted the fix-default-args branch September 16, 2020 16:23
@clrcrl clrcrl mentioned this pull request Jan 6, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtcohen6 jtcohen6 jtcohen6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to override database name
2 participants
@clrcrl @jtcohen6