Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added quote_columns=(true | false) flag to the unique_combination_of_columns.sql macro #270

Merged
merged 2 commits into from
Sep 3, 2020
Merged

Added quote_columns=(true | false) flag to the unique_combination_of_columns.sql macro #270

merged 2 commits into from
Sep 3, 2020

Conversation

JoshuaHuntley
Copy link
Contributor

…ng of columns.

This is a:

  • bug fix PR with no breaking changes (please change the base branch to main)
  • new functionality
  • a breaking change

Description & motivation

Checklist

  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to the changelog

@JoshuaHuntley JoshuaHuntley requested a review from clrcrl as a code owner August 28, 2020 17:12
@clrcrl
Copy link
Contributor

clrcrl commented Sep 3, 2020 •
edited
Loading

I've tested this out locally with quote_columns: true and it works as expected across Redshift, BigQuery and Snowflake! Running the integration tests now :)

@clrcrl clrcrl merged commit 7d26745 into dbt-labs:dev/0.6.0 Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clrcrl clrcrl clrcrl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshuaHuntley @clrcrl