Allow aliasing individual columns from star macro. #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliottohara
commented
Jun 10, 2020
| @@ -0,0 +1,16 @@ | |||
|
|
|||
| -- TODO : Should the star macro use a case-insensitive comparison for the `except` field on Snowflake? | |||
There was a problem hiding this comment.
Yes, I think it should, I'll PR that soon enough! :)
|
Kicking off the tests :) |
3 tasks
|
Closing in favor of #245 (had to rebase) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
I love the
starmacro! I often find myself excluding columns just so I can alias them. This leads to less DRY code than I'd like, so I extended star to take an optional dictionary{colname:aliasname}and it will then alias the columns as expected.Checklist