Can grant access to emails (user, group, SA) #8357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inlined
force-pushed
the
inlined.grantaccess-user
branch
from
89a7a5b to
57f26df
Compare
taeold
approved these changes
Mar 24, 2025
src/apphosting/secrets/index.ts
Outdated
| } | ||
|
|
||
| /** | ||
| * Grants the following users or grouips access to the provided secret. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Grants the following users or grouips access to the provided secret. | |
| * Grants the following users or groups access to the provided secret. |
src/apphosting/secrets/index.ts
Outdated
| existingBindings = (await gcsm.getIamPolicy({ projectId, name: secretName })).bindings || []; | ||
| } catch (err: unknown) { | ||
| throw new FirebaseError( | ||
| `Failed to get IAM bindings on secret: ${secretName}. Ensure you have the permissions to do so and try again.`, |
Contributor
There was a problem hiding this comment.
What if we link to https://cloud.google.com/secret-manager/docs/manage-access-to-secrets#required-roles to guide the users a little more here?
I'd love to link to a Firebase doc, but seems like we don't have a doc.
| ) | ||
| .option("-l, --location <location>", "backend location", "-") | ||
| .option("-b, --backend <backend>", "backend name") | ||
| .option("-u, --emails <emails>", "comma delmited list user or group emails") |
Contributor
There was a problem hiding this comment.
Want to update the short flag too or keep it?
Suggested change
| .option("-u, --emails <emails>", "comma delmited list user or group emails") | |
| .option("-e, --emails <emails>", "comma delmited list user or group emails") |
| ) | ||
| .option("-l, --location <location>", "backend location", "-") | ||
| .option("-b, --backend <backend>", "backend name") | ||
| .option("-u, --emails <emails>", "comma delmited list user or group emails") |
Contributor
There was a problem hiding this comment.
Suggested change
| .option("-u, --emails <emails>", "comma delmited list user or group emails") | |
| .option("-u, --emails <emails>", "comma delimited list user or group emails") |
| const accounts = secrets.toMulti(secrets.serviceAccountsForBackend(projectNumber, backend)); | ||
|
|
||
| await secrets.grantSecretAccess(projectId, projectNumber, secretName, accounts); | ||
| await Promise.all( |
| .description("grant service accounts permissions to the provided secret") | ||
| export const command = new Command("apphosting:secrets:grantaccess <secretNames>") | ||
| .description( | ||
| "grant service accounts permissions to the provided secret(s). Can pass one or more secrets, separated by a comma", |
Contributor
There was a problem hiding this comment.
Suggested change
| "grant service accounts permissions to the provided secret(s). Can pass one or more secrets, separated by a comma", | |
| "grant service accounts or users permissions to the provided secret(s). Can pass one or more secrets, separated by a comma", |
taeold
approved these changes
Mar 24, 2025
| const accounts = secrets.toMulti(secrets.serviceAccountsForBackend(projectNumber, backend)); | ||
|
|
||
| await Promise.all( | ||
| await Promise.allSettled( |
Contributor
There was a problem hiding this comment.
Wanna explicitly handle errors here?
Or we could just go back to using Promise.all() instead... 🤷🏼
e.g.
const results = await Promise.allSettled(
secretList.map((secretName) =>
secrets.grantSecretAccess(projectId, projectNumber, secretName, accounts)
)
);
const failures = results.filter(result => result.status === 'rejected');
if (failures.length > 0) {
throw new Error(`Failed to grant access to ${failures.length}/${results.length} secrets`);
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the new work to encourage the use of test secrets in the emulator.
Unfortunately there is no general API to figure out whether an email address is a service account, user, or group. Fortunately, IAM will return an error with a clear message on what type of principal the secret was on error so we can brute force our way to success ¯_(ツ)_/¯