Clean up logs when using FIREBASE_DATACONNECT_POSTGRESQL_STRING #7882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuchenshi
approved these changes
Oct 28, 2024
| @@ -310,6 +310,9 @@ You can probably fix this by running "npm install ${systemLog.data.name}@latest" | |||
| case "BULLET": | |||
| utils.logLabeledBullet(label, text, "info", mergedData); | |||
| break; | |||
| case "INFO": | |||
| utils.logLabeledBullet(label, text, "info", mergedData); | |||
There was a problem hiding this comment.
Why do we need this in addition to BULLET?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing a couple logging bugs that made it seem like PGLite was running even when FIREBASE_DATACONNECT_POSTGRESQL_STRING was used.
Scenarios Tested
With FIREBASE_DATACONNECT_POSTGRESQL_STRING (corrected the capitalization inconsistency on the log label)
Without:
