Reorder firebase init dataconnect prompts for better local onboarding flow.
#7733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosalyntan
changed the title
firebase init dataconnect prompts for better local onboarding flow.
joehan
approved these changes
Sep 26, 2024
| }), | ||
| ); | ||
| if (existingServicesAndSchemas.length) { | ||
| const choices: { name: string; value: any }[] = existingServicesAndSchemas.map((s) => { |
There was a problem hiding this comment.
Nit:
Suggested change
| const choices: { name: string; value: any }[] = existingServicesAndSchemas.map((s) => { | |
| const choices: { name: string; value: { schema: Schema, service: Service } | undefined }[] = existingServicesAndSchemas.map((s) => { |
| }; | ||
| }); | ||
| choices.push({ name: "Create a new service", value: undefined }); | ||
| const choice: { service: Service; schema: Schema } = await promptOnce({ |
There was a problem hiding this comment.
If you set it above, you can remove this type declaration here because promptOnce will return a defined type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Scenarios Tested
Sample Commands
project with billing with existing services:
project with billing with no services, (n) for configuring backend resources:
