fix: identify dependencies that might require the --no-tree-shake-icons flag #7724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flutter-tree-shake
…-tools into fix/flutter-tree-shake
leoortizz
requested changes
Sep 24, 2024
leoortizz
reviewed
Sep 24, 2024
leoortizz
reviewed
Oct 1, 2024
jamesdaniels
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Thanks. LGTM. Let's add changelog, i'll let @leoortizz shepherd the final approval and merge
leoortizz
requested changes
Oct 8, 2024
Co-authored-by: Leonardo Ortiz <[email protected]>
…flutter-tree-shake
leoortizz
requested changes
Oct 10, 2024
Co-authored-by: Leonardo Ortiz <[email protected]>
leoortizz
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to this issue: #6197
Trying to identify dependencies that might require the --no-tree-shake-icons build flag.
Unfortunately can not allow users to pass arbitrary/custom flags when running the
deployfunction, so tried to identify dependencies that are likely to require the flag to build.Scenarios Tested
fixes #6197