Make firebase init for FDC work better with Spark projects.
#7666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joehan
reviewed
Sep 17, 2024
| const prefix = "dataconnect"; | ||
| // These are the APIs that can be enabled without a billing account. | ||
| await ensure(projectId, api.dataconnectOrigin(), prefix); | ||
| await ensure(projectId, api.cloudSQLAdminOrigin(), prefix); |
There was a problem hiding this comment.
Huh, TIL that this API doesn't require billing
There was a problem hiding this comment.
Yeah I was a little surprised by that haha
joehan
approved these changes
Sep 17, 2024
fredzqm
approved these changes
Sep 17, 2024
| const prefix = "dataconnect"; | ||
| // These are the APIs that can be enabled without a billing account. | ||
| await ensure(projectId, api.dataconnectOrigin(), prefix); | ||
| await ensure(projectId, api.cloudSQLAdminOrigin(), prefix); |
rosalyntan
added a commit
that referenced
this pull request
Sep 17, 2024
rosalyntan
added a commit
that referenced
this pull request
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For projects without billing enabled, do not enable the compute.googleapis.com API nor provision a CloudSQL instance during
firebase init.Scenarios Tested
firebase initwith Spark projectfirebase initwith Blaze projectSample Commands
firebase initwith Spark project