Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repeated prompt for Firebase Extensions TOS in v13.15.4 #7590

Closed
LeriLoper opened this issue Aug 23, 2024 · 4 comments
Closed

Repeated prompt for Firebase Extensions TOS in v13.15.4 #7590

LeriLoper opened this issue Aug 23, 2024 · 4 comments
Assignees
@ifielker
Labels
api: extensions type: bug

Comments

@LeriLoper
Copy link

Environment info

firebase-tools: 13.15.4

Node.js: 20.14.0

Platform: Windows

[REQUIRED] Test case

Deploy a function using the Firebase CLI using firebase-tools v13.15.4.

[REQUIRED] Steps to reproduce

  1. Upgrade to firebase-tools v13.15.4.
  2. Deploy any function using the Firebase CLI:
    firebase deploy --only functions
  3. The prompt with the question "Do you accept the Firebase Extensions User Terms of Service? (Y/n)" appears.
  4. Deploy any function again using the same method.
  5. The same prompt appears.

[REQUIRED] Expected behavior

  1. Either save the reply the first time we answer the prompt.
  2. Or have a special option like --skipExtensionsTOS.

[REQUIRED] Actual behavior

The prompt appears every time we deploy a function using the Firebase CLI. Stalling our deployment scripts.

Note that -f & --force don't solve this issue, due to the fact that these options also "delete Cloud Functions missing from the current working directory", and I only mean to bypass the extensions TOS prompt.
@t0mstah
Copy link

t0mstah commented Aug 26, 2024

Plz

@AdrianLsk
Copy link

Workaround for people not using extensions: turn off the firebaseextensions.googleapis.com API in the API library in GCP console.

@m-j-g
Copy link

m-j-g commented Aug 27, 2024

I've been getting the same prompt every deploy, real annoying. I noticed when updating that it added this to .firebaserc:

"targets": {},
"etags": {
"app-name": {
"extensionInstances": {}
}
},
"dataconnectEmulatorConfig": {}

@joehan
Copy link
Contributor

joehan commented Aug 27, 2024

Hey everyone, apologies for the trouble here. We're rolling out a new way to declare extensions from within your functions codebases soon, and this change was meant to se the table for that. However, it ended up negatively users who installed extensions via the console and deploy only their functions via CLI. We're reverting this behavior change for now and will release a version today to get the changes out(dee2c89).

Later, we'll revisit this feature and will roll it out again in a less disruptive way.

@joehan joehan closed this as completed Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ifielker ifielker

Labels
api: extensions type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@AdrianLsk @joehan @t0mstah @m-j-g @LeriLoper @ifielker @aalej