Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update data connect client, dataplaneclient, and emulator client to v… #7589

Merged
merged 7 commits into from
Sep 18, 2024
Merged

update data connect client, dataplaneclient, and emulator client to v… #7589

merged 7 commits into from
Sep 18, 2024

Conversation

hlshen
Copy link
Contributor

@hlshen hlshen commented Aug 23, 2024 •
edited
Loading

Do not release until emulator updates endpoints

@hlshen hlshen requested a review from joehan August 23, 2024 17:47
@hlshen hlshen marked this pull request as draft August 23, 2024 19:33
joehan
joehan requested changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests in dataconnect/client.spec.ts are failing - looks like you just need to update the references to v1alpha in there as well.

@hlshen hlshen requested a review from joehan September 3, 2024 16:52
@hlshen hlshen marked this pull request as ready for review September 3, 2024 16:52
@hlshen hlshen enabled auto-merge (squash) September 13, 2024 17:58
@rosalyntan rosalyntan mentioned this pull request Sep 16, 2024
Merged
48 tasks
@hlshen hlshen merged commit c222f52 into master Sep 18, 2024
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joehan joehan joehan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hlshen @joehan