fix: handle paths with spaces in getGlobalEsbuildVersion function #7571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
dxdc
force-pushed
the
dxdc-next-patch-1
branch
from
64d799d
to
3583843
Compare
joehan
approved these changes
Aug 20, 2024
|
Looks like there are test failures for this, please fix. |
|
done |
|
@leoortizz PTAL |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7571 +/- ##
==========================================
- Coverage 56.91% 56.90% -0.01%
==========================================
Files 396 396
Lines 27599 27599
Branches 5692 5692
==========================================
- Hits 15708 15706 -2
- Misses 11723 11725 +2
Partials 168 168 ☔ View full report in Codecov by Sentry. |
leoortizz
added a commit
that referenced
this pull request
Sep 18, 2024
leoortizz
added a commit
that referenced
this pull request
Sep 18, 2024
joehan
added a commit
that referenced
this pull request
Sep 18, 2024
* add changelog for #7571 * Update CHANGELOG.md --------- Co-authored-by: joehan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Scenarios Tested
Sample Commands