Add support for cloud tasks within the emulator. #7475
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| defaultUri: string; | ||
|
|
||
| // The configurations below this point do not currently have any effect on how the task queues are handled within the emulator | ||
| secrets?: string[]; // TODO(gburroughs): look into how we can handle this |
There was a problem hiding this comment.
Secrets should be handled by the functions emulator at startup, but it would be good to confirm this.
| const tasksAddr = legacyGetFirstAddr(Emulators.TASKS); | ||
| const tasksEmulator = new TasksEmulator({ | ||
| host: tasksAddr.host, | ||
| port: tasksAddr.port, | ||
| }); | ||
|
|
||
| await startEmulator(tasksEmulator); |
There was a problem hiding this comment.
Q: does this mean we always run the task emulator whenever we run the functions emulator?
I think this is fine for now, but I think an ideal solution would run the task emulator only if a task queue function is defined.
I don't know whether something like that is possible, but if you have time would love for you to see if that's even feasible.
There was a problem hiding this comment.
Yes, the task queue emulator is run whenever the functions emulator is run.
There is the code here:
firebase-tools/src/emulator/tasksEmulator.ts
Line 215 in 03297d5
which only starts the listening logic of the task queue emulator once an actual task has been enqueued to avoid doing unnecessary updates while the user isn't doing anything with task queues in their functions code. The express server is still spun up every time the functions emulator starts though.
There was a problem hiding this comment.
Hmm I wonder if we should instead have Task Queue Emulators be explicitly started, just like the Pub/sub emulator.
@blidd-google thoughts?
|
Overriding the CLA check here as Garret worked on this during his time at Google. |
* register cloud task triggers * Create and register task queue emulator * Add basic features of task queue emulator * Implement a queue to improve performance of tasks emulator * Remove unused import * Register task queues from functions emulator * change task queue endpoint to accept IDs in body instead of query params * set enviornment variable when task queue emulator is running * Remove bug where tasks were getting dispatched too fast * Rework task enqueueing API and support task deletion * properly support task deletion * Refactor Task Dispatching Algorithm * Add task deduplication for all tasks that have ever been added * Refactor Task Queue * Add tests for task queue emulator * respond to PR review * update firebase-config.json * use node-fetch * fix tests * Make tasks emulator start up whenever functions emulator starts * fix error message * Add statistics endpoint * Add in global task deduplication * Add headers to request * Review Changes * Remove console logs * Update backoff calculations * add changelog --------- Co-authored-by: blidd-google <[email protected]> Co-authored-by: joehan <[email protected]> Co-authored-by: Brian Li <[email protected]>
4 participants
Support for cloud tasks within the emulator