Fixes secret params resolution in functions emulator #7443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalej
reviewed
Jul 12, 2024
There was a problem hiding this comment.
This LGTM! Tested the PR using https://github.com/aalej/issues-7401?tab=readme-ov-file#pr-test. Could you add a changelog entry?
aalej
approved these changes
Jul 16, 2024
joehan
reviewed
Jul 16, 2024
src/deploy/functions/build.ts
Outdated
| @@ -279,13 +279,15 @@ export async function resolveBackend( | |||
| userEnvOpt: UserEnvsOpts, | |||
| userEnvs: Record<string, string>, | |||
| nonInteractive?: boolean, | |||
| isEmulator = false, | |||
There was a problem hiding this comment.
Optional: this list of args is quite long, and it would be easy to transpose nonInteractive and isEmulator. Consider switching to a parameter object. ie:
export async function resolveBackend( args: {
build: Build,
firebaseConfig: FirebaseConfig,
userEnvOpt: UserEnvsOpts,
userEnvs: Record<string, string>,
nonInteractive?: boolean,
isEmulator?: boolean,
})
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functions emulator will try to resolve secrets twice - we disable the secret resolution in deploy flow's
resolveBackend(which is reused by the emulator to discover functions triggers) so the emulator can access handle emulator-specific secret resolution (i.e. prioritizing .secret.local).Fixes #7401.