Fix bug where secret values provided in env files were parsed as list. #7422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blidd-google
approved these changes
Jul 8, 2024
|
Nice to see this fixed! FYI, one of the reasons secrets end up in .env files is because of a bug when using the emulator and a demo- project. As a workaround to the bug, putting an empty secret in the .env file works, but perhaps some devs forget that this is just a workaround and the var should just be empty. See more here: #5520 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Values for secret params defined using
defineSecretare not supposed to be provided in env files. Instead, secret values should be created and managed in Cloud Secret Manager.However, users often do include values for secret params in their env files, and today CLI incorrectly treats it as a list due to a bug that assumed that secret values will never be provided in the env files.
The change here treats values for secrets in env files as string.
Fixes firebase/firebase-functions#1567