Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL rewrites not working on static assets with firebase deploy on firebase-tools@^13.9.0 #7363

Closed
wongchichong opened this issue Jun 22, 2024 · 9 comments · Fixed by #7382
Closed

Comments

@wongchichong
Copy link

firebase-tools:

Windows

firebase deploy --only hosting

with firebase-tools > v13.9.0

      {
        "source": "**",
        "destination": "/index.html"
      }

not working on static assets.
all graphics not loading.

downgrading to [email protected]

static assets works again.

@Fric56
Copy link

Fric56 commented Jun 22, 2024

Same here.
[email protected]) was the last version that worked for me.

@JackTezos
Copy link

Same!
Thanks, switching to 13.9.0 saves me a lot of time!

@pogorv12
Copy link

Same with me.

I spotted that the number of deployed files decreased after update. So for me it looks like files located in subfolders of public dir are not deployed.

@aalej
Copy link
Contributor

aalej commented Jun 24, 2024

Hey folks, sorry to hear you’re encountering this issue and thanks for reporting this. At the moment, I can’t seem to reproduce the issue on macOS machines. However, I was able to reproduce this on a Windows machine.

I’ll raise this to our engineering team so that we can investigate the cause of the issue. For those encountering this, could you let me know if you’re also using a Windows machine?

As a workaround, please use v13.11.2. I was able to deploy to Firebase Hosting without any issues using this version.

@ksmutny
Copy link

ksmutny commented Jun 24, 2024

Encountered the same problem. 13.11.2 works for me, 13.11.3 and 13.11.4 do not.

Windows 11 Pro 23H2, Node 21.7.3., firebase-tools installed globally.

Encountered also with a deploy from GitHub Actions, which runs on windows-latest.

It seems to me the problem is not rewrites, but uploading the assets. I was unable to load them using the real path. (e.g. html/en/index.html). It happened on my production server, so I didn't investigate too much and redeployed using 13.11.2.

@pureimpro
Copy link

Same issue for me, on Windows, workaround by downgrading to 13.11.2, after numerous hours of headache

@Robula
Copy link

Robula commented Jun 25, 2024

Likely related #7378

@Wrakie
Copy link

Wrakie commented Jun 26, 2024

I spent the whole day trying to figure out what I did wrong 😭😭😭

@seborys40
Copy link

wtf?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.