Fix path issue in Windows deployments for Next.js SSR #7148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoortizz
added a commit
that referenced
this pull request
May 9, 2024
leoortizz
changed the title
jamesdaniels
approved these changes
May 13, 2024
Member
jamesdaniels
left a comment
jamesdaniels
left a comment
There was a problem hiding this comment.
LGTM, we're in codefreeze RN. We can merge once lifted
This was referenced May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
realpathoption in Windows was conflicting withabsolute: false, causing glob to return absolute paths in Windows. Now that relative paths are expected and the final path is built withjoin, we don't needrealpathanymore.Fixes #7146.
Scenarios Tested
https://github.com/firebase/firebase-tools/actions/runs/9022861095/job/24793571043?pr=7032
Sample Commands