Adds *.local to .gitignore and functions ignore for functions setup #7018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blidd-google
approved these changes
Apr 23, 2024
blidd-google
pushed a commit
that referenced
this pull request
May 1, 2024
…7018) * Adds *.local to .gitignore and functions ignore for javascript,typescript, and python templates * Added changelog entry --------- Co-authored-by: joehan <[email protected]>
mathu97
pushed a commit
that referenced
this pull request
May 6, 2024
…7018) * Adds *.local to .gitignore and functions ignore for javascript,typescript, and python templates * Added changelog entry --------- Co-authored-by: joehan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7017
Add
*.localto thefunctions.ignorelist infirebase.jsonfile and the.gitignoreby default to avoid accidentally leaking secret valuesScenarios Tested
firebase init functions --project PROJECT_IDJavaScript
functions/.gitignorefirebase.json{ "functions": [ { "source": "functions", "codebase": "default", "ignore": [ "node_modules", ".git", "firebase-debug.log", "firebase-debug.*.log", "*.local" ] } ] }TypeScript
functions/.gitignorefirebase.json{ "functions": [ { "source": "functions", "codebase": "default", "ignore": [ "node_modules", ".git", "firebase-debug.log", "firebase-debug.*.log", "*.local" ], "predeploy": [ "npm --prefix \"$RESOURCE_DIR\" run lint", "npm --prefix \"$RESOURCE_DIR\" run build" ] } ] }Python
functions/.gitignorefirebase.json{ "functions": [ { "source": "functions", "codebase": "default", "ignore": [ "venv", ".git", "firebase-debug.log", "firebase-debug.*.log", "*.local" ] } ] }Sample Commands
firebase init functions