Fixes a deployment crash when resetting min instances to 0 in v1 functions #6990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blidd-google
approved these changes
Apr 11, 2024
inlined
pushed a commit
that referenced
this pull request
Apr 11, 2024
…tions (#6990) * fix the falsy value from not being calculated * add changelog entry
inlined
added a commit
that referenced
this pull request
Apr 17, 2024
) * Move to an AST model for configs for minimal diffs * Remove js-yaml as a direct dependency * Fix --only firestore:rules,firestore:indexes edge case (#6966) * Fix --only firestore:rules,firestore:indexes edge case * Added changelog entry * increase supported Astro version to 4 (#6960) * Fixes a deployment crash when resetting min instances to 0 in v1 functions (#6990) * fix the falsy value from not being calculated * add changelog entry * Remove superfluous parse statement * PR feedback * formatter- * Splice supported library to unbreak json schema generation * JSDoc comment * Formatter --------- Co-authored-by: aalej <[email protected]> Co-authored-by: Leonardo Ortiz <[email protected]> Co-authored-by: Cole Rogers <[email protected]>
mathu97
pushed a commit
that referenced
this pull request
Apr 18, 2024
) * Move to an AST model for configs for minimal diffs * Remove js-yaml as a direct dependency * Fix --only firestore:rules,firestore:indexes edge case (#6966) * Fix --only firestore:rules,firestore:indexes edge case * Added changelog entry * increase supported Astro version to 4 (#6960) * Fixes a deployment crash when resetting min instances to 0 in v1 functions (#6990) * fix the falsy value from not being calculated * add changelog entry * Remove superfluous parse statement * PR feedback * formatter- * Splice supported library to unbreak json schema generation * JSDoc comment * Formatter --------- Co-authored-by: aalej <[email protected]> Co-authored-by: Leonardo Ortiz <[email protected]> Co-authored-by: Cole Rogers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a fasly check that would treat 0 min instances as false instead of true and crash the deployment - #6980