Fix --only firestore:rules,firestore:indexes edge case #6966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joehan
approved these changes
Apr 10, 2024
Member
joehan
left a comment
joehan
left a comment
There was a problem hiding this comment.
Took me a couple reads to understand, but this looks correct to me! Thanks!
inlined
pushed a commit
that referenced
this pull request
Apr 11, 2024
* Fix --only firestore:rules,firestore:indexes edge case * Added changelog entry
inlined
added a commit
that referenced
this pull request
Apr 17, 2024
) * Move to an AST model for configs for minimal diffs * Remove js-yaml as a direct dependency * Fix --only firestore:rules,firestore:indexes edge case (#6966) * Fix --only firestore:rules,firestore:indexes edge case * Added changelog entry * increase supported Astro version to 4 (#6960) * Fixes a deployment crash when resetting min instances to 0 in v1 functions (#6990) * fix the falsy value from not being calculated * add changelog entry * Remove superfluous parse statement * PR feedback * formatter- * Splice supported library to unbreak json schema generation * JSDoc comment * Formatter --------- Co-authored-by: aalej <[email protected]> Co-authored-by: Leonardo Ortiz <[email protected]> Co-authored-by: Cole Rogers <[email protected]>
mathu97
pushed a commit
that referenced
this pull request
Apr 18, 2024
) * Move to an AST model for configs for minimal diffs * Remove js-yaml as a direct dependency * Fix --only firestore:rules,firestore:indexes edge case (#6966) * Fix --only firestore:rules,firestore:indexes edge case * Added changelog entry * increase supported Astro version to 4 (#6960) * Fixes a deployment crash when resetting min instances to 0 in v1 functions (#6990) * fix the falsy value from not being calculated * add changelog entry * Remove superfluous parse statement * PR feedback * formatter- * Splice supported library to unbreak json schema generation * JSDoc comment * Formatter --------- Co-authored-by: aalej <[email protected]> Co-authored-by: Leonardo Ortiz <[email protected]> Co-authored-by: Cole Rogers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6857
When running
firebase deploy --only firestore:rules,firestore:indexes, nothing gets deployed since we determine what gets deployed based on what is excluded. This is because of a different edge case #6129.Adding includes should let
firebase-toolsknow if either/bothfirestore:rulesor/andfirestore:indexesis included. Leaving comments as using both exclude and include is confusing.Scenarios Tested
firebase deploy --only firestore:rules,firestore:indexes